🍒 [lldb] Fix crash missing MSInheritanceAttr with DWARF on Windows (#112928) #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows (llvm#112928) Member pointers refer to data or function members of a `CXXRecordDecl`, which require a `MSInheritanceAttr` in order to be complete. Without that we cannot calculate the size of a member pointer in memory. The attempt has been causing a crash further down in the clang AST context. In order to implement the feature, DWARF will need a new attribtue to convey the information. For the moment, this patch teaches LLDB to handle to situation and avoid the crash.
|
We could add llvm#115177 here as well if it gets reviewed soon. |
llvm#115177) Following up from llvm#112928, we can reuse the approach from Clang Sema to infer the MSInheritanceModel and add the necessary attribute manually. This allows the inspection of member function pointers with DWARF on Windows.
|
@hjyamauchi @compnerd It would be great to land these cherry-picks in isolation from #9513 Can you trigger the CI please? |
|
@swift-ci please test |
|
Windows build failed for an unrelated reason. Didn't reach the test stage. |
|
@swift-ci please test Windows Platform |
|
@swift-ci please test Windows platform |
compnerd
approved these changes
Dec 2, 2024
weliveindetail
deleted the
cherrypick-lldb-msabi-member-pointers-crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Member pointers refer to data or function members of a
CXXRecordDecl, which require aMSInheritanceAttrin order to be complete. Without that we cannot calculate the size of a member pointer in memory. The attempt has been causing a crash further down in the clang AST context. In order to implement the feature, DWARF might need a new attribute to convey the information. For the moment, this patch teaches LLDB to handle to situation and avoid the crash.