Update SE-0192 for Swift 6 language mode #2450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,7 @@ | |||
| * Author: [Jordan Rose](https://github.com/jrose-apple) | |||
| * Review Manager: [Ted Kremenek](https://github.com/tkremenek) | |||
| * Status: **Implemented (Swift 5.0)** | |||
| * Upcoming Feature Flag: `NonfrozenEnumExhaustivity` (implemented in Swift 6.0 to subsume bespoke compiler flag for Swift 4/4.2 language mode) | |||
There was a problem hiding this comment.
Suggested change
| * Upcoming Feature Flag: `NonfrozenEnumExhaustivity` (implemented in Swift 6.0 to subsume bespoke compiler flag for Swift 4/4.2 language mode) | |
| * Upcoming Feature Flag: `NonfrozenEnumExhaustivity` (implemented in Swift 6.0) (enabled in Swift 6 language mode) |
This should also include the (enabled in Swift 6 language mode) annotation to indicate when the flag is always enabled.
The details of what an upcoming feature flag does is not included as part of the header field. The details should be generally be included in the "Source Compatibility" section or elsewhere in the proposal. In this case, in the introduction.
There was a problem hiding this comment.
This is tricky to explain. It is enabled in Swift 5 language mode too; the flag has no effect except in Swift 4/4.2 mode.
| @@ -21,6 +22,8 @@ A key note: in this version of the proposal, *nothing changes for user-defined S | |||
|
|
|||
| - Since the proposal was accepted months after it was written, the rollout plan turned out to be a little too aggressive. Therefore, in Swift 5 the diagnostic for omitting `@unknown default:` or `@unknown case _:` will only be a warning, and in Swift 4 mode there will be no diagnostic at all. (The previous version of the proposal used an error and a warning, respectively.) Developers are still free to use `@unknown` in Swift 4 mode, in which case the compiler will still produce a warning if all known cases are not handled. | |||
|
|
|||
| - To complete the rollout of this feature, the warning is [upgraded to an error for the Swift 6 language mode](https://forums.swift.org/t/amendment-se-0192-handling-future-enum-cases/68321) | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| The upcoming feature flag `NonfrozenEnumExhaustivity` is implemented in Swift 6.0 to subsume the bespoke compiler flag for Swift 4/4.2 language mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize this proposal with the language steering group's amendment for the Swift 6 language mode, as announced and implemented for Swift 6.0.