Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SE-0371] Isolated synchronous deinit is accepted #2558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SE-0371] Isolated synchronous deinit is accepted #2558

wants to merge 1 commit into from

Conversation

benrimmington
Copy link
Contributor

@benrimmington benrimmington commented Sep 5, 2024 •
edited
Loading

Update status and review fields.

Cc: @Jumhyn, @nickolas-pohilets

@benrimmington benrimmington mentioned this pull request Sep 5, 2024
Open
@ktoso
Copy link
Contributor

ktoso commented Sep 5, 2024

LGTM though I'm not sure we need to do it via the "amended" wording in the text -- we should just change the text to reflect the accepted revision I think?

And add the change to the changelog at the bottom.

cc @rjmccall @hborla

@benrimmington

This comment was marked as outdated.

Sign in to view
@benrimmington
[SE-0371] Isolated synchronous deinit is accepted
96b90fd 
Update status and review fields.
@benrimmington benrimmington changed the title Update 0371-isolated-synchronous-deinit.md [SE-0371] Isolated synchronous deinit is accepted Sep 15, 2024
@benrimmington
Copy link
Contributor Author

I've changed this pull request so that it only updates the status and review fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benrimmington @ktoso @Naveen-C-Ramachandrappa