[SE-0085] Add a package subcommand to handle package-oriented operations
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions. This moves the package-management commands from the `build` subcommand to `package`, but leaves building (and, currently, cleaning) on the `build` subcommand. The `test` subcommand is likewise unmodified. I had to temporarily move down the enums for InitMode and ShowDependen- ciesMode, so that both package and build can share them, but this will be consolidated again when build and test are reimplemented in terms of package as well. The build and test functionality is not yet moved in order to minimize changes while still ending up with the desired func- tionality.
abertelrud
force-pushed
the
package-subcommand
branch
from
9df72a6 to
84e7ac1
Compare
| print(" --verbose Increase verbosity of informational output [-v]") | ||
| print(" -Xcc <flag> Pass flag through to all C compiler instantiations") | ||
| print(" -Xlinker <flag> Pass flag through to all linker instantiations") | ||
| print(" -Xswiftc <flag> Pass flag through to all Swift compiler instantiations") |
There was a problem hiding this comment.
Random thought, I wonder if xcodeproj generation might be ok to leave on swift build? That would allow us to keep all build related options there. From a certain perspective it is a "different way of building" although obvious from other perspectives it is a completely separate command.
There was a problem hiding this comment.
I considered that, but it really didn't feel right from a usage perspective. We can open up a separate SE for that, I think. There is still some refactoring to do here, and I think we can find a way to not have to repeat this information, from a technical perspective (through a richer way of being able to define options, and which options apply to which subcommands).
|
LGTM! |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
[gtest] Simplify include structure for gtest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the package-management commands from the
buildsubcommand topackage, but leaves building (and, currently, cleaning) on thebuildsubcommand. The
testsubcommand is likewise unmodified.I had to temporarily move down the enums for InitMode and ShowDependen-
ciesMode, so that both package and build can share them, but this will
be consolidated again when build and test are reimplemented in terms of
package as well. The build and test functionality is not yet moved in
order to minimize changes while still ending up with the desired func-
tionality.