Plumb through the testing library version into a function instead of a C++ macro. #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a macro. This PR moves the consumption of the testing library version (via C++ macro `SWT_TESTING_LIBRARY_VERSION`) to a C++ function. It seems that defining it in CMake for C++ targets doesn't trigger for the Swift side when it imports symbols from C headers. Will verify with a toolchain build.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
Verified this works in a toolchain build:
|
|
Self-reviewing. @briancroom is aware of the change. |
This was referenced Aug 28, 2024
grynspan
added a commit
that referenced
this pull request
Aug 28, 2024
…ad of a C++ macro. (#649) **Explanation:** Correctly sets the testing library version (it was failing to set on the Swift side.) **Scope:** Building with CMake **Issue:** N/A **Original PR:** #648 **Risk:** Low **Testing:** Built a toolchain and verified the string was ingested all the way through. **Reviewer:** @grynspan @briancroom
grynspan
added a commit
that referenced
this pull request
Aug 29, 2024
…tead of a C++ macro. (#650) **Explanation:** Correctly sets the testing library version (it was failing to set on the Swift side.) **Scope:** Building with CMake **Issue:** N/A **Original PR:** #648 **Risk:** Low **Testing:** Built a toolchain and verified the string was ingested all the way through. **Reviewer:** @grynspan @briancroom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the consumption of the testing library version (via C++ macro
SWT_TESTING_LIBRARY_VERSION) to a C++ function. It seems that defining it in CMake for C++ targets doesn't trigger for the Swift side when it imports symbols from C headers.Will verify with a toolchain build.
Checklist: