[6.0] Reduce overhead of .expectationChecked event handling in #expect() (take 2)
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pect()`. (#657) **Explanation:** Optimizes the implementation of `#expect()`, in particular the parts that ask for fully-qualified type names and generate `.expectationChecked` events. **Scope:** 6.0 branch **Issue:** N/A **Original PR:** #610 **Risk:** Moderate—refactors code inside `#expect()` and introduces a new lock and atomic value used by them. **Testing:** New unit test coverage, existing coverage. **Reviewer:** @briancroom @suzannaratcliff
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
grynspan
changed the title
.expectationChecked event handling in #expect() (take 2)
stmontgomery
approved these changes
Sep 4, 2024
briancroom
approved these changes
Sep 4, 2024
|
Toolchain build isn't 100% complete, but it's past building Swift Testing, so we appear to be in the clear. |
grynspan
deleted the
jgrynspan/jgrynspan/133517028-minimize-expectationChecked-overhead-6.0-take-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Optimizes the implementation of
#expect(), in particular the parts that ask for fully-qualified type names and generate.expectationCheckedevents.Scope: 6.0 branch
Issue: N/A
Original PR: #610, also includes fixup commit 6ba948a
Risk: Moderate—refactors code inside
#expect()and introduces a new lock and atomic value used by them.Testing: New unit test coverage, existing coverage.
Reviewer: @briancroom @suzannaratcliff