Don't use swift_enumerateAllMetadataSections() on WASI.
#730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
grynspan
commented
Sep 24, 2024
| @@ -213,24 +213,8 @@ struct SWTTypeMetadataRecord { | |||
| } | |||
| }; | |||
|
|
|||
| #if defined(SWT_NO_DYNAMIC_LINKING) | |||
There was a problem hiding this comment.
Moved this bit down to clarify it's "Apple with static linking" rather than all static-linked cases. The code isn't changed.
stmontgomery
approved these changes
Sep 24, 2024
|
Tested with wasmtime! |
|
@swift-ci test |
On WASI, there is only a single statically-linked binary, so we don't need to use `swift_enumerateAllMetadataSections()` and can just directly access the bounds of the metadata section(s) we care about.
grynspan
force-pushed
the
jgrynspan/wasi-no-swift_enumerateAllMetadataSections
branch
from
18d5810 to
a5e98bb
Compare
|
@swift-ci test |
kateinoigakukun
approved these changes
Sep 24, 2024
grynspan
deleted the
jgrynspan/wasi-no-swift_enumerateAllMetadataSections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On WASI, there is only a single statically-linked binary, so we don't need to use
swift_enumerateAllMetadataSections()and can just directly access the bounds of the metadata section(s) we care about.Checklist: