-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachments! [Take 2] #796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
New feature or request
swiftpm-integration
Swift Package Manager integration
tools integration
Integration of swift-testing into tools/IDEs
public-api
Affects public API
attachments/activities
🖇️ Work related to attachments and/or activities
labels
Nov 2, 2024
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
November 2, 2024 17:24
This PR introduces a new experimental feature, attachments. With this feature, you can "attach" values that conform to a new `Test.Attachable` protocol to a test. With the right command-line incantation (TBD), Swift Testing will automatically write attachments to disk for you. > ![NOTE] > This PR does not teach Xcode or VS Code how to handle attachments produced by > Swift Testing, nor does it add the necessary command-line arguments to the > `swift test` command-line tool. This PR is one of a series that I'll be posting to build out this feature. As always, keep in mind that symbols marked `@_spi(Experimental)` are subject to change or removal without notice. Resolves #714. Resolves rdar://88648735.
…er temporary directory by default
…ur CI configuration, is actually set up.
grynspan
force-pushed
the
jgrynspan/attachments
branch
from
November 3, 2024 00:54
e5d6a59
to
3e94088
Compare
@swift-ci test |
@swift-ci test Linux |
@swift-ci test macOS |
briancroom
approved these changes
Nov 3, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
attachments/activities
🖇️ Work related to attachments and/or activities
enhancement
New feature or request
public-api
Affects public API
swiftpm-integration
Swift Package Manager integration
tools integration
Integration of swift-testing into tools/IDEs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new experimental feature, attachments. With this feature, you can "attach" values that conform to a new
Test.Attachable
protocol to a test. With the right command-line incantation (TBD), Swift Testing will automatically write attachments to disk for you.Note
This PR does not teach Xcode or VS Code how to handle attachments produced by
Swift Testing, nor does it add the necessary command-line arguments to the
swift test
command-line tool.This PR is one of a series that I'll be posting to build out this feature.
As always, keep in mind that symbols marked
@_spi(Experimental)
are subject to change or removal without notice.Resolves #714.
Resolves rdar://88648735.
Checklist: