Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Testing: add some force unwraps for Android #830

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Nov 19, 2024

Add some force unwraps to address nullability differences on Android from other platforms.

(cherry picked from commit d080ee2)

Motivation:

This is needed to build the release/6.0 branch of testing for Android.

Modifications:

Add force unwraps where they were needed.

Result:

Android swift-testing builds on the release/6.0 branch.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

Add some force unwraps to address nullability differences on Android
from other platforms.

(cherry picked from commit d080ee2)
@hyp hyp requested a review from compnerd November 19, 2024 16:49
@hyp hyp changed the title Testing: add some force unwraps for Android [release/6.0] Testing: add some force unwraps for Android Nov 19, 2024
@grynspan grynspan added this to the Swift 6.1 milestone Nov 19, 2024
@grynspan grynspan added bug Something isn't working android 🤖 Android support labels Nov 19, 2024
@grynspan grynspan modified the milestones: Swift 6.1, Swift 6.0.3 Nov 19, 2024
@grynspan
Copy link
Contributor

Needs approval from @briancroom before merging.

@grynspan
Copy link
Contributor

You are free to merge (ping me if you don't see the Big Green Button!)

@compnerd compnerd merged commit 7efdd76 into release/6.0 Nov 20, 2024
@compnerd compnerd deleted the android/6pick branch November 20, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android 🤖 Android support bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants