Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ConstraintSystem] Record trailing choice match choice when arguments… #34356

Merged
merged 1 commit into from
Oct 19, 2020
Merged

[ConstraintSystem] Record trailing choice match choice when arguments… #34356

merged 1 commit into from
Oct 19, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 19, 2020

…/result are equivalent to applied function

@xedin xedin requested a review from hborla October 19, 2020 20:57
@xedin
Copy link
Contributor Author

xedin commented Oct 19, 2020 •
edited
Loading

I don't think it's possible to hit this with current constraint generation because ConstraintGenerator::visitApplyExpr would always introduce a type variable for result type but I encountered this while working on some changes where subtyping is not supported for result types. Good use-case for a unit test :)

@xedin
Copy link
Contributor Author

xedin commented Oct 19, 2020

@swift-ci please smoke test

@xedin xedin merged commit a0a37d2 into swiftlang:main Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @hborla