Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"There is no active transaction" exception thrown during transformations (PHP 8) #47

Closed
michalbiarda opened this issue Nov 17, 2022 · 0 comments
Closed

"There is no active transaction" exception thrown during transformations (PHP 8) #47

michalbiarda opened this issue Nov 17, 2022 · 0 comments
Assignees
@michalbiarda
Labels
bug
Milestone
4.0.0

Comments

@michalbiarda
Copy link
Contributor

On PHP 8 \Driver\Engines\MySql\Transformation::applyTransformationsTo throws "There is no active transaction" exception when processing query that is autocomitted (eg. ALTER TABLE). On previous versions of PHP the error was silent.

Having in mind that we are processing single queries there, transactions are not needed, we can remove them completely.
@michalbiarda michalbiarda added this to the 4.0.0 milestone Nov 17, 2022
@michalbiarda michalbiarda self-assigned this Nov 17, 2022
@michalbiarda michalbiarda moved this to In Progress in Driver Nov 17, 2022
michalbiarda added a commit that referenced this issue Nov 17, 2022
@michalbiarda
#47: Removed unnecessary transactions from transformation function
8edbe1d
JesseMaxwell added a commit that referenced this issue Nov 17, 2022
@JesseMaxwell
Merge pull request #49 from swiftotter/47-no-active-transaction
e841212 
#47: Removed unnecessary transactions from transformation function
@michalbiarda michalbiarda moved this from In Progress to QA in Driver Nov 24, 2022
@michalbiarda michalbiarda moved this from QA to Done in Driver Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalbiarda michalbiarda

Labels
bug
Projects
Driver
Status: Done
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@michalbiarda