Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SO-Driver-29: Change of config folders names #32

Merged
merged 3 commits into from
Jun 30, 2022
Merged

SO-Driver-29: Change of config folders names #32

merged 3 commits into from
Jun 30, 2022

Conversation

prince-swiftotter
Copy link
Contributor

Worked for : #29

michalbiarda
michalbiarda requested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@michalbiarda michalbiarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the config folder name to .driver (with a dot) everywhere. This should be the only option (driver should be removed).

@prince-swiftotter
Copy link
Contributor Author

Please change the config folder name to .driver (with a dot) everywhere. This should be the only option (driver should be removed).

I've kept it driver instead of .driver so that it won't remain hidden at root of the project. Changed all references now. Please review.

michalbiarda
michalbiarda requested changes Jun 30, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@michalbiarda michalbiarda self-requested a review June 30, 2022 08:46
@michalbiarda michalbiarda merged commit 322a42c into 4.0-develop Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbiarda michalbiarda michalbiarda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prince-swiftotter @michalbiarda