Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid installing deprecated Python 2 from Homebrew #160

Merged
merged 5 commits into from
Feb 17, 2020

Conversation

MaxDesiatov
Copy link

brew install python@2 now fails for me locally due to Homebrew/homebrew-core#49796, not sure how it still runs fine on CI, probably due to caches not being cleaned up as frequently.

I hope relying on system-installed Python should work fine.

@kateinoigakukun
Copy link
Member

Running lit tests on Linux VM on GitHub Actions takes too long time.
It reached the execution time limit of GitHub Actions 😢

Each job in a workflow can run for up to 6 hours of execution time. If a job reaches this limit, the job is terminated and fails to complete. There are no time limits for self-hosted runners.

https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits

We have to consider another way to run the lit tests continuously, but for the moment, I think it's OK to stop running test and remove -t flag from build-script.

@MaxDesiatov
Copy link
Author

MaxDesiatov commented Feb 15, 2020

I was wondering whether we can precompile llvm and clang as a job in our llvm-project fork. Maybe as a Docker image that can be then used to run jobs in this repo, based on swiftwasm-linux-builder?

@kateinoigakukun
Copy link
Member

I think it's great worth to prepare pre-built llvm binary on Docker 👍
Only my concern is whether ninja cache system works expectedly.

@MaxDesiatov MaxDesiatov force-pushed the maxd/remove-homebrew-python branch from 192f8c5 to 6b79918 Compare February 16, 2020 13:02
@MaxDesiatov MaxDesiatov merged commit 9ce40f2 into swiftwasm Feb 17, 2020
@MaxDesiatov MaxDesiatov deleted the maxd/remove-homebrew-python branch February 17, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants