Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

dynamic grouping/tree fix #257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonshaffer
Copy link

Fix for #212

  1. In demo, sets group:true to 1 column (the code only accounts for this anyways at this time)
  2. pulled refreshTree, refreshGroup logic into its own method for calling on groupColumn || treeColumn change
  3. added a watch on the options.columns that updates group/tree for the table
  4. moved conditional scope.watches from the constructor to a method that gets reevaluated if columns ever change

@@ -12,74 +12,112 @@ export class BodyController{
constructor($scope, $timeout){
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove $timeout here && on doc


this.setTreeAndGroupColumns();

this.setConditionalWatches();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be more accurate be on a watch for options.scrollbarV && options.paging.externalPaging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant