Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing problem with support preset mode #35

Merged
merged 2 commits into from
Nov 7, 2022
Merged

fixing problem with support preset mode #35

merged 2 commits into from
Nov 7, 2022

Conversation

alvarocarrera
Copy link
Contributor

After updating set_hvac the _support_flags is properly updated. Moreover, the deprecated imports have been replaced with the new ClimateEntityFeature enum.

@alvarocarrera
fixing problem with support preset mode
799c48e 
After updating set_hvac the _support_flags is properly updated.
Moreover, the deprecated imports have been replaced with the new
ClimateEntityFeature enum.
swingerman
swingerman requested changes Nov 4, 2022
View reviewed changes
Copy link
Owner

@swingerman swingerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that tests are green

@sebastian-steinmann sebastian-steinmann mentioned this pull request Nov 5, 2022
Closed
@alvarocarrera
Copy link
Contributor Author

The problem was that the ClimateEntityFeature enum (available in core github repo: https://github.com/home-assistant/core/blob/dev/homeassistant/components/climate/const.py ) is not available yet in the pytest-homeassistant-custom-component==0.8.7 module. Now all tests passed.

@swingerman swingerman merged commit e2504c5 into swingerman:master Nov 7, 2022
@swingerman
Copy link
Owner

The problem was that the ClimateEntityFeature enum (available in core github repo: https://github.com/home-assistant/core/blob/dev/homeassistant/components/climate/const.py ) is not available yet in the pytest-homeassistant-custom-component==0.8.7 module. Now all tests passed.

Thanks mate!

@alvarocarrera
Copy link
Contributor Author

The problem was that the ClimateEntityFeature enum (available in core github repo: https://github.com/home-assistant/core/blob/dev/homeassistant/components/climate/const.py ) is not available yet in the pytest-homeassistant-custom-component==0.8.7 module. Now all tests passed.

Thanks mate!

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swingerman swingerman swingerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarocarrera @swingerman