Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MLx related integration tests #110

Merged
merged 18 commits into from
Jul 18, 2022
Merged

Implement MLx related integration tests #110

merged 18 commits into from
Jul 18, 2022

Conversation

damb
Copy link
Collaborator

@damb damb commented Jun 16, 2022

  • Most of the tests were implemented based on the data provided by @mmesim within Implement MLx integration tests #75.
  • Amplitude waveform identifiers include both the band and the source code identifiers form the channel code.

Closes #75.

@damb damb added magnitude Refers to magnitude related topics amplitude Refers to amplitude related topics tests Unit and integration test related topics labels Jun 16, 2022
@damb damb self-assigned this Jun 16, 2022
@damb damb force-pushed the feature/iss-75 branch from 4372644 to 8866f7f Compare June 20, 2022 12:49
@damb
Copy link
Collaborator Author

damb commented Jun 20, 2022

@mmesim, I added some more MLx related tests.

As discussed, could you please compute the results from the integration-tests

  • magnitude/MLx/single-detector-single-stream-0003
  • magnitude/MLx/single-detector-multi-stream-0003
  • magnitude/MLx/single-detector-multi-stream-0004

independently? (You'll find the test data in the src/apps/cc/test/data/integration/ directory.) Note that I'm going to look into the latter two tests, again by myself, as well. The MLx magnitudes seem somehow inconsistent.

Thanks.

@damb
Copy link
Collaborator Author

damb commented Jun 20, 2022

OT: This is detection related (and not MLx amplitude/magnitude related). In the context of the integration-tests

  • magnitude/MLx/single-detector-multi-stream-0004

I noted an interesting behavior when increasing the "arrivalOffsetThreshold" to e.g. 0.2, i.e. instead of detecting the template origin (2019-11-05T05:23:47.640489Z), only, an additional detection is emitted (2019-11-05T05:23:29.035489Z).

@damb damb requested a review from mmesim June 20, 2022 16:23
Daniel Armbruster added 13 commits July 15, 2022 18:02
Note that detection is performed on the horizontal components (once on
the first horizontal component, once on the second horizontal
component).

Note also that with this commit the tests are not configured, yet (i.e.
in the `dataset.conf`).
Detect on vertical component, while MLx is computed based on the
horizontal components.
Fix memory leak when executing multiple `MLx` amplitude/magnitude
integration tests. The static index was not cleared properly during
resetting the `magnitude::Factory`.

At the time being, an index is most probably not required, anyway.
Use multiple streams from different sensor locations. Use multiple
template families.
@damb damb force-pushed the feature/iss-75 branch from 0b03c56 to 7b26252 Compare July 15, 2022 18:54
@damb
Copy link
Collaborator Author

damb commented Jul 15, 2022

Attached the notebook used to validate the tests. Credits to @mmesim.

MLx_test_01.ipynb.gz

Note that the actual implementation uses a slightly different order when it comes to preprocessing the data. E.g. the data is filtered before it is deconvoluted.

@damb damb removed the request for review from mmesim July 15, 2022 19:04
@damb damb merged commit 8ec68ed into master Jul 18, 2022
@damb damb deleted the feature/iss-75 branch July 18, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplitude Refers to amplitude related topics magnitude Refers to magnitude related topics tests Unit and integration test related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MLx integration tests
1 participant