Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): Added post-linkarea component (3830) #4030

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

veyaromain
Copy link
Contributor

@veyaromain veyaromain commented Nov 20, 2024

No description provided.

@veyaromain veyaromain requested review from a team as code owners November 20, 2024 07:30
@veyaromain veyaromain linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 1f27679

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-documentation Minor
@swisspost/design-system-components Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles Minor
@swisspost/design-system-tokens Minor
@swisspost/design-system-intranet-header Minor
@swisspost/design-system-icons Minor
@swisspost/design-system-migrations Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header-showcase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 20, 2024

Related Previews

@veyaromain
Copy link
Contributor Author

@alizedebray do you now why i get this code smell? This h import is used by <slot>

@alizedebray
Copy link
Contributor

@alizedebray do you now why i get this code smell? This h import is used by <slot>

@veyaromain this is a false positive, I just accepted the issue on SonarCloud

Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is very clean, well done! 👍
I've added a few change requests. If you need more details about anything, feel free to ask.

Copy link

@gfellerph gfellerph mentioned this pull request Dec 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[component]: Link area
3 participants