Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): fix focus indicator visibility for links in accordion items inside the footer on mobile #4306

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(styles): fix focus indicator visibility for links in accordion items inside the footer on mobile #4306

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c54916
fix(styles): fix focus indicator visibility for links in accordion it…
alionazherdetska Dec 16, 2024
99bbea1
Revert "fix(styles): fix focus indicator visibility for links in acco…
alionazherdetska Dec 18, 2024
b540d1c
fix(styles): added overflow visible for open `post-collapsible`
alionazherdetska Dec 18, 2024
7aab945
chore(code style): removed redundant spaces
alionazherdetska Dec 18, 2024
23e17a5
chore(code style): removed redundant spaces
alionazherdetska Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/src/components/post-collapsible/post-collapsible.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { collapse, expand } from '@/animations/collapse';
import { checkEmptyOrType, isMotionReduced } from '@/utils';

/**
* @part collapsible-container - The pseudo-element, used to override styles on the collapsible element.
* @slot default - Slot for placing content within the collapsible element.
*/

Expand Down Expand Up @@ -96,7 +97,7 @@ export class PostCollapsible {

render() {
return (
<Host data-version={version}>
<Host data-version={version} part="collapsible-container">
<slot />
</Host>
);
Expand Down
7 changes: 7 additions & 0 deletions packages/components/src/components/post-collapsible/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ Type: `Promise<boolean>`
| `"default"` | Slot for placing content within the collapsible element. |


## Shadow Parts

| Part | Description |
| ------------------------- | ----------------------------------------------------------------------- |
| `"collapsible-container"` | The pseudo-element, used to override styles on the collapsible element. |


## Dependencies

### Used by
Expand Down
4 changes: 4 additions & 0 deletions packages/components/src/components/post-footer/post-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ footer {
::part(body) {
padding-inline: 0;
}
::part(collapsible-container) {
margin-inline: -1rem;
padding-inline: 1rem;
}
}

.footer-column {
Expand Down
Loading