Skip to content

Commit

Permalink
Revert app versioning attempt with APP_VERSION integration; scoping i…
Browse files Browse the repository at this point in the history
…s limited.
  • Loading branch information
swoocn committed Mar 30, 2024
1 parent e974085 commit 2e1e596
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 23 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ name: Map of Pi CI/CD [Release]

# Controls when the workflow will execute
on:
pull_request:
branches:
- dev
# Triggers the workflow on publised releases
release:
types: [published]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { CommonModule } from '@angular/common';
import { TranslateModule } from '@ngx-translate/core';
import { RouterModule } from '@angular/router';

import { environment } from '../../../environments/environment';

@Component({
selector: 'app-information',
standalone: true,
Expand All @@ -16,10 +14,7 @@ import { environment } from '../../../environments/environment';
export class InformationComponent {
showPopup: boolean = true;

/* pull the APP_VERSION GitHub Environment Variable that is set in the GitHub Actions workflow that is configured in the release.yml;
if the runtime value does not exist i.e., browser environment, then pull the static value. */
version: string = environment.version;

version: string = 'Beta V2.0';
logo: string = "../../assets/images/logo.svg";
email: string = 'info@mapofpi.com';

Expand Down
7 changes: 0 additions & 7 deletions frontend/src/environments/environment.development.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
declare const process: {
env: {
APP_VERSION: string;
};
};

export const environment = {
isSandbox: true,
version: typeof process !== 'undefined' && process.env.APP_VERSION ? 'Beta V' + process.env.APP_VERSION : 'Beta V2.0'
};
7 changes: 0 additions & 7 deletions frontend/src/environments/environment.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
declare const process: {
env: {
APP_VERSION: string;
};
};

export const environment = {
isSandbox: false,
version: typeof process !== 'undefined' && process.env.APP_VERSION ? 'Beta V' + process.env.APP_VERSION : 'Beta V2.0'
};

0 comments on commit 2e1e596

Please sign in to comment.