-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix out of sources tree build #5239
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5239 +/- ##
==========================================
+ Coverage 72.95% 72.96% +0.01%
==========================================
Files 69 69
Lines 14858 14858
==========================================
+ Hits 10839 10841 +2
+ Misses 4019 4017 -2 ☔ View full report in Codecov by Sentry. |
Notice: It will be nice to use some out of sources tree build in CI
|
Notice, pecl-install.sh is not enough See https://github.com/swoole/swoole-src/actions/runs/7635384707/job/20800724466 Yes, the extension is built, but with mising sources it is unusable Ex:
So, adding such a minimal load test may be useful too. |
Second commit add such a test P.S. Notice, the check will work fully when PHP is built using |
Broken by eb9a16e and 03b2639
Notice: pecl build use out of sources tree build
So tagged version 5.1.2 will be unusable there