Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop saving events to GCP datastore / replace message ID #725

Closed
frytg opened this issue Sep 4, 2024 · 1 comment · Fixed by #733
Closed

Stop saving events to GCP datastore / replace message ID #725

frytg opened this issue Sep 4, 2024 · 1 comment · Fixed by #733
Assignees
Labels
feature New feature or request

Comments

@frytg
Copy link
Member

frytg commented Sep 4, 2024

// save message to datastore
const savedMessage = await datastore.save(message, 'events')
message.id = savedMessage.id.toString()

  • stop saving to datastore
  • generate ID using ULID + some other identifier (unique and preferably sortable)
  • potentially use cloud store to save elements (with automatic retention/deletion policy)

warn subscribers about change to IDs

@frytg frytg added the feature New feature or request label Sep 4, 2024
@frytg frytg changed the title Stop saving elements to GCP datastore Stop saving events to GCP datastore Sep 4, 2024
@frytg frytg changed the title Stop saving events to GCP datastore Stop saving events to GCP datastore / replace message ID Sep 24, 2024
@frytg
Copy link
Member Author

frytg commented Oct 25, 2024

btw, ULID already in use here

name: `${prefix}${ULID.ulid()}`,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants