Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stop storing the message in the gcp datastore #733

Merged
merged 2 commits into from
Oct 30, 2024
Merged

feat: stop storing the message in the gcp datastore #733

merged 2 commits into from
Oct 30, 2024

Conversation

Steinertech9
Copy link
Contributor

resolves #725

@Steinertech9 Steinertech9 added feature New feature or request dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code safe to test Only apply to PRs when test runs should be executed labels Oct 28, 2024
@Steinertech9 Steinertech9 requested a review from frytg October 28, 2024 15:27
@Steinertech9 Steinertech9 self-assigned this Oct 28, 2024
@Steinertech9 Steinertech9 linked an issue Oct 28, 2024 that may be closed by this pull request
Stop saving events to GCP datastore / replace message ID #725
Closed
frytg
frytg requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@frytg frytg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception during run: Error [ERR_REQUIRE_ESM]: require() of ES Module /home/runner/work///node_modules/slug/slug.js from /home/runner/work///src/utils/pubsub/createSubscription.js not supported.
https://github.com/swrlab/ard-eventhub/actions/runs/11557239317/job/32166792550

@Steinertech9 Steinertech9 force-pushed the dev/725-stop-saving-events-to-gcp-datastore--replace-message-id branch 22 times, most recently from cb8f274 to 9875821 Compare October 29, 2024 07:44
@Steinertech9 Steinertech9 force-pushed the dev/725-stop-saving-events-to-gcp-datastore--replace-message-id branch from 9875821 to c06d6df Compare October 29, 2024 07:56
@Steinertech9 Steinertech9 requested a review from frytg October 29, 2024 07:58
@frytg frytg merged commit 618cc9f into main Oct 30, 2024
6 checks passed
@frytg frytg deleted the dev/725-stop-saving-events-to-gcp-datastore--replace-message-id branch October 30, 2024 09:08
@github-actions GitHub Actions
Copy link

Docker container is ready!

VERSION:

1.9.2-g666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frytg frytg frytg approved these changes

Assignees

@Steinertech9 Steinertech9

Labels
dependencies Pull requests that update a dependency file feature New feature or request javascript Pull requests that update Javascript code safe to test Only apply to PRs when test runs should be executed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop saving events to GCP datastore / replace message ID
2 participants
@Steinertech9 @frytg