Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints output of exec to the current process' stdout, stderr, & stdline #139

Merged
merged 10 commits into from
Feb 21, 2024
Merged

Prints output of exec to the current process' stdout, stderr, & stdline #139

merged 10 commits into from
Feb 21, 2024

Conversation

mikepigott
Copy link
Contributor

@mikepigott mikepigott commented Feb 21, 2024

Description

The primary purpose of this change is to add a listener to the call to exec.exec(...) so any output to the sub-process's stdout, stderr, and stdline are forwarded to the parent process's stdout, stderr, and stdline, effectively.

I also made some refactoring changes:

  • The second parameter to exec.exc is the process's arguments as a list, so I converted the cmd creation to an array of args.
  • I also converted the set of deployment options to an array of arguments, and used .join(',') to convert it to a single command-line argument as a comma-separated list.

Fixes #137

Type of change

Please delete options that are not relevant.

  • [√] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • [√] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [√] My changes generate no new warnings

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

dist/index.js Show resolved Hide resolved
@rhahao
Copy link
Member

rhahao commented Feb 21, 2024

Thanks @mikepigott for this PR. I hope it is now much more readable with better feedback if something went wrong. Greetings,

@rhahao rhahao merged commit 9fc9677 into sws2apps:main Feb 21, 2024
8 checks passed
@mikepigott
Copy link
Contributor Author

It was! I was able to figure out how to properly configure my release process and give the service account the correct permissions.

@rhahao
Copy link
Member

rhahao commented Feb 21, 2024

🎉 This PR is included in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Action Fails to Deploy With No Output
2 participants