Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Commit

Permalink
fix(app): change firebase.json to use build folder
Browse files Browse the repository at this point in the history
  • Loading branch information
rhahao committed Feb 6, 2022
1 parent 2df1042 commit 307a6e3
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 40 deletions.
5 changes: 3 additions & 2 deletions .firebaserc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"projects": {
"development": "dev-lmm-oa-sws",
"staging": "staging-lmm-oa-sws",
"production": "lmm-oa-sws"
"production": "lmm-oa-sws",
"default": "lmm-oa-sws"
},
"targets": {}
}
}
18 changes: 4 additions & 14 deletions .github/workflows/deploy-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,6 @@ jobs:
node-version: [16.x]

steps:
- name: Checkout for firebase deployment
uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579
with:
repository: danielmillan/pipelines-firebase-hosting
ref: '1.0.8'
token: ${{ secrets.GH_TOKEN }}
persist-credentials: false
path: ./.github/actions/pipelines-firebase-hosting

- name: Checkout for release preparation
uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579
with:
Expand Down Expand Up @@ -54,8 +45,7 @@ jobs:

- name: Deploy to Firebase
if: ${{ steps.check_build.outputs.files_exists == 'true' }}
uses: ./.github/actions/pipelines-firebase-hosting
with:
firebase-token: ${{ secrets.FIREBASE_TOKEN }}
resources-name: build
project-name: ${{ secrets.FIREBASE_PROJECT }}
uses: doonstore/firebase-deploy@3c07a0714007ef3bec30f35ed62f43b13cf48ad5
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
FIREBASE_PROJECT: ${{ secrets.FIREBASE_PROJECT }}
18 changes: 4 additions & 14 deletions .github/workflows/rebuild-deploy-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,6 @@ jobs:
node-version: [16.x]

steps:
- name: Checkout for firebase deployment
uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579
with:
repository: danielmillan/pipelines-firebase-hosting
ref: '1.0.8'
token: ${{ secrets.GH_TOKEN }}
persist-credentials: false
path: ./.github/actions/pipelines-firebase-hosting

- name: Checkout for release preparation
uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579
with:
Expand All @@ -52,8 +43,7 @@ jobs:

- name: Deploy to Firebase
if: ${{ steps.check_build.outputs.files_exists == 'true' }}
uses: ./.github/actions/pipelines-firebase-hosting
with:
firebase-token: ${{ secrets.FIREBASE_TOKEN }}
resources-name: build
project-name: ${{ secrets.FIREBASE_PROJECT }}
uses: doonstore/firebase-deploy@3c07a0714007ef3bec30f35ed62f43b13cf48ad5
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
FIREBASE_PROJECT: ${{ secrets.FIREBASE_PROJECT }}
24 changes: 14 additions & 10 deletions firebase.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"hosting": {
"public": "public",
"ignore": ["firebase.json", "**/.*", "**/node_modules/**"],
"rewrites": [
{
"source": "**",
"destination": "/index.html"
}
]
}
"hosting": {
"public": "build",
"ignore": [
"firebase.json",
"**/.*",
"**/node_modules/**"
],
"rewrites": [
{
"source": "**",
"destination": "/index.html"
}
]
}
}

0 comments on commit 307a6e3

Please sign in to comment.