Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dynamic OG images PR #145

Closed
wants to merge 21 commits into from
Closed

add Dynamic OG images PR #145

wants to merge 21 commits into from

Conversation

swyxio
Copy link
Owner

@swyxio swyxio commented Dec 11, 2022

closes #125

@swyxio
Copy link
Owner Author

swyxio commented Dec 11, 2022

this PR is DOA unless yisibl/resvg-js#175 is fixed

@swyxio
Copy link
Owner Author

swyxio commented Dec 23, 2022

many thanks to https://github.com/geoffrich/sveltekit-satori-mdsvex-test and https://app.netlify.com/sites/lovely-blancmange-a2af75/deploys for proving there is nothing fundamentally wrong with the setup.

however it is still causing an issue on my end https://app.netlify.com/sites/swyxkit/functions/render?scope=deploypreview:145
image

@geoffrich
Copy link

Would anything in the netlify.toml be causing issues? Otherwise idk what's different between my repo and yours.

@swyxio
Copy link
Owner Author

swyxio commented Dec 23, 2022

no idea. the only option i have left is a ground up rewrite (starting with your repo as base, porting over stuff one by one until something breaks) to figure this out

so i am leaving this til later haha

@swyxio
Copy link
Owner Author

swyxio commented Jan 15, 2023

giving up on this for now since #161 is a good-enough if temporary solution

@swyxio swyxio closed this Jan 15, 2023
@ak4zh
Copy link
Collaborator

ak4zh commented Jan 15, 2023

This one looks useful: https://github.com/etherCorps/sveltekit-og

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically generated og:images
3 participants