Update StepChoosers in example yaml files

sxs-collaboration · May 15, 2024 · 4c67a0b · 4c67a0b
1 parent dfda335
commit 4c67a0b
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 12 deletions.
diff --git a/support/Pipelines/Bbh/Inspiral.yaml b/support/Pipelines/Bbh/Inspiral.yaml
@@ -112,6 +112,7 @@ Evolution:
   StepChoosers:
     - LimitIncrease:
         Factor: 2
+    - PreventRapidIncrease
     - ElementSizeCfl:
         SafetyFactor: 0.5
     - ErrorControl:

diff --git a/tests/InputFiles/CurvedScalarWave/PlaneWaveMinkowski1D.yaml b/tests/InputFiles/CurvedScalarWave/PlaneWaveMinkowski1D.yaml
@@ -38,6 +38,7 @@ Evolution:
   StepChoosers:
     - LimitIncrease:
         Factor: 2
+    - PreventRapidIncrease
     - Cfl:
         SafetyFactor: 0.2
 

diff --git a/tests/InputFiles/CurvedScalarWave/PlaneWaveMinkowski2D.yaml b/tests/InputFiles/CurvedScalarWave/PlaneWaveMinkowski2D.yaml
@@ -38,6 +38,7 @@ Evolution:
   StepChoosers:
     - LimitIncrease:
         Factor: 2
+    - PreventRapidIncrease
     - Cfl:
         SafetyFactor: 0.2
 

diff --git a/tests/InputFiles/CurvedScalarWave/PlaneWaveMinkowski3D.yaml b/tests/InputFiles/CurvedScalarWave/PlaneWaveMinkowski3D.yaml
@@ -53,6 +53,7 @@ Evolution:
   StepChoosers:
     - LimitIncrease:
         Factor: 2
+    - PreventRapidIncrease
     - Cfl:
         SafetyFactor: 0.2
 

diff --git a/tests/InputFiles/GeneralizedHarmonic/CylindricalBinaryBlackHole.yaml b/tests/InputFiles/GeneralizedHarmonic/CylindricalBinaryBlackHole.yaml
@@ -22,6 +22,7 @@ Evolution:
   StepChoosers:
     - LimitIncrease:
         Factor: 2
+    - PreventRapidIncrease
     - ElementSizeCfl:
         SafetyFactor: 0.5
     - ErrorControl:

diff --git a/tests/InputFiles/GrMhd/ValenciaDivClean/FishboneMoncriefDisk.yaml b/tests/InputFiles/GrMhd/ValenciaDivClean/FishboneMoncriefDisk.yaml
@@ -29,6 +29,7 @@ Evolution:
   # StepChoosers:
   #   - LimitIncrease:
   #       Factor: 2
+  #   - PreventRapidIncrease
   #   - Cfl:
   #       SafetyFactor: 0.2
   # InitialSlabSize is only needed for local time stepping

diff --git a/tests/InputFiles/NewtonianEuler/RiemannProblem1D.yaml b/tests/InputFiles/NewtonianEuler/RiemannProblem1D.yaml
@@ -104,24 +104,17 @@ EventsAndTriggers:
           # number has little qualitative effect on chosen step size,
           # as long as the initial step size is not too large for the
           # requested accuracy.
-          DelayChange: &slab_update_delay 10
+          DelayChange: 10
           StepChoosers:
             - ErrorControl:
                 AbsoluteTolerance: 1.0e-3
                 RelativeTolerance: 1.0e-3
                 MaxFactor: 10000.0
                 MinFactor: 0.0
                 SafetyFactor: 0.9
-  # These step choosers require no communication, so can be applied
-  # with a delay of 0 with no downside.  We don't want them to start
-  # increasing the slab size before the error control is active,
-  # though.
-  - Trigger:
-      SlabCompares:
-        Comparison: GreaterThanOrEqualTo
-        Value: *slab_update_delay
-    Events:
       - ChangeSlabSize:
+          # These step choosers require no communication, so can be
+          # applied with a delay of 0 with no downside.
           DelayChange: 0
           StepChoosers:
             - LimitIncrease:

diff --git a/tests/InputFiles/ScalarTensor/KerrSchildSphericalHarmonic.yaml b/tests/InputFiles/ScalarTensor/KerrSchildSphericalHarmonic.yaml
@@ -34,6 +34,7 @@ Evolution:
   StepChoosers:
     - LimitIncrease:
         Factor: 2
+    - PreventRapidIncrease
     - Cfl:
         SafetyFactor: 0.2
 

diff --git a/tests/InputFiles/ScalarWave/PlaneWave3D.yaml b/tests/InputFiles/ScalarWave/PlaneWave3D.yaml
@@ -81,8 +81,6 @@ EventsAndTriggers:
       - ChangeSlabSize:
           DelayChange: 0
           StepChoosers:
-            - LimitIncrease:
-                Factor: 1.1
             - StepToTimes:
                 Times:
                   Specified: