-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monte carlo packets #4089
Monte carlo packets #4089
Conversation
ae1cf13
to
183cff1
Compare
${LIBRARY} | ||
"Evolution/Particles/MonteCarlo" | ||
"${LIBRARY_SOURCES}" | ||
"Boost::boost;Evolution;Utilities" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are missing MonteCarlo
in this list
Better is to update this to the following (which is what we are slowly doing to all test directories):
- Change line 14 to just be an empty list
""
- Add the following to the end of the file:
target_link_libraries(
${LIBRARY}
PRIVATE
Monte Carlo
)
592960a
to
aac9a69
Compare
d18e135
to
fe0c3d9
Compare
@kidder : The code for the evolution of a single packet for a time step along a geodesic seems to pass the standard tests now. I'm not sure what a more appropriate test would be here; the one I implemented is obviously simplistic. I could write a python function reproducing the whole second-order time stepping, and compare results with random inputs, I guess? It's not clear to me whether we will actually perform time steps using this method, or incorporate the time-stepping within another part of the code once we try to actually move packets on a grid. Apart from that, I think this PR is ready for review (and, obviously, fairly low priority...). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few small comments you can squash right away when you rebase
41494bb
to
4f7fe63
Compare
4f7fe63
to
9727a0c
Compare
@nilsdeppe More changes than I'd have liked in order to match the latest clang-tidy requirements, but this should be ready for you again. Note that I needed to add a default constructor to the packet struct -- clang-tidy was unhappy with packet creation that did not explicitly set the contents of the packet. |
(The failing test is some paraview thing... I'm guessing this has nothing to do with this PR) |
CI failure is some unrelated paraview thing. |
Proposed changes
Add packets for MC evolutions, and ability to evolve packets along a geodesic
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments
Very preliminary; packets cannot at this point be included in actual evolution...