Add the exact Wald solution to ForceFree system #5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoonso0-0
force-pushed
the
ffe/exact_wald
branch
4 times, most recently
from
3f287ea
to
6d8f000
Compare
wthrowe
requested changes
Oct 11, 2023
| namespace ForceFree::Solutions { | ||
|
|
||
| ExactWald::ExactWald(const double magnetic_field_amplitude, | ||
| const Options::Context& /*context*/) |
There was a problem hiding this comment.
[optional] If you don't use the context you can omit the argument and the option parser will figure out not to pass it.
| p | magnetic_field_amplitude_; | ||
| } | ||
|
|
||
| PUP::able::PUP_ID ExactWald::my_PUP_ID = 0; |
There was a problem hiding this comment.
Just NOLINT this to make clang-tidy happy. We can't do anything about charm internals.
| struct MagneticFieldAmplitude { | ||
| using type = double; | ||
| static constexpr Options::String help = { | ||
| "Amplitude of initial magnetic field along z axis."}; |
There was a problem hiding this comment.
This is time-independent, so remove "initial".
|
|
||
| /*! | ||
| * \brief An exact electrovacuum solution of Maxwell's equations in the Kerr | ||
| * spacetime found by Wald \cite Wald1974. |
There was a problem hiding this comment.
Kerr -> Schwarzschild? The paper is valid for arbitrary spin, but only the zero-spin case is implemented (and I take it that the spinning case isn't a solution to the force-free equations.)
| #include "PointwiseFunctions/AnalyticSolutions/ForceFree/FastWave.hpp" | ||
| #include "Utilities/TMPL.hpp" | ||
|
|
||
| namespace ForceFree::Solutions { | ||
| /*! | ||
| * \brief Typelist of all analytic solutions of GRFFE evolution system | ||
| */ | ||
| using all_solutions = tmpl::list<AlfvenWave, FastWave>; | ||
| using all_solutions = tmpl::list<AlfvenWave, FastWave, ExactWald>; |
| const std::unique_ptr<InitialData> deserialized_base_ptr = | ||
| serialize_and_deserialize(base_ptr)->get_clone(); | ||
| CHECK(dynamic_cast<const ExactWald&>(*deserialized_base_ptr.get()) == | ||
| dynamic_cast<const ExactWald&>(*base_ptr.get())); |
There was a problem hiding this comment.
Remove .get() form these two lines.
yoonso0-0
force-pushed
the
ffe/exact_wald
branch
from
6d8f000
to
6ab54bc
Compare
|
Looks good. Squash. |
yoonso0-0
force-pushed
the
ffe/exact_wald
branch
2 times, most recently
from
5d6bdad
to
57a6127
Compare
|
Squashed and rebased on develop. Thanks for review. |
yoonso0-0
force-pushed
the
ffe/exact_wald
branch
from
57a6127
to
ee0012f
Compare
wthrowe
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.