Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Sphere TimeDependentOptions #5542

Merged

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Oct 5, 2023

Removes the ability to independently specify size coefficients because it wasn't used in practice. If we need to specify size coefficients we should do it from a file.

Proposed changes

Upgrade instructions

To use hard coded time dependent maps with the Sphere domain creator, you no longer specify the following option

  TimeDependentMaps:
    ...
    SizeMap:  # <-- Don't specify this
      InitialValues: [...]

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 requested a review from nilsvu October 5, 2023 23:11
@knelli2 knelli2 force-pushed the sphere_time_dep_opt_cleanup branch from 4709389 to 3a9d4f5 Compare October 5, 2023 23:43
Removes the ability to independently specify size coefficients
because it wasn't used in practice. If we need to specify size
coefficients we should do it from a file.
@knelli2
Copy link
Contributor Author

knelli2 commented Oct 16, 2023

@nilsvu Could you take a look at this? It's some prep to make #5541 simpler.

@nilsvu nilsvu merged commit 6b5d00a into sxs-collaboration:develop Oct 18, 2023
22 checks passed
@nilsvu
Copy link
Member

nilsvu commented Oct 18, 2023

Add some upgrade instruction please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants