Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to Schedule.py #5547

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Oct 7, 2023

Proposed changes

Preparation for #5546.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Oct 7, 2023
@nilsvu nilsvu force-pushed the py_schedule branch 2 times, most recently from 878b52d to 397d6c6 Compare October 9, 2023 16:40
Clearer name IMO, and not a verb.
Allows other CLI commands to use the option.
This option is mainly used to skip submission with Slurm, but makes
sense to use it also when no scheduler is used.
@knelli2 knelli2 merged commit e8b9ac7 into sxs-collaboration:develop Oct 9, 2023
22 checks passed
@nilsvu nilsvu deleted the py_schedule branch October 13, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants