Make magnetic field configuration runtime choice #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
changed the title
kidder
requested changes
Oct 17, 2023
src/PointwiseFunctions/AnalyticData/GrMhd/InitialMagneticFields/Poloidal.cpp
Show resolved
Hide resolved
src/PointwiseFunctions/AnalyticData/GrMhd/InitialMagneticFields/Poloidal.hpp
Show resolved
Hide resolved
src/PointwiseFunctions/AnalyticData/GrMhd/InitialMagneticFields/Toroidal.hpp
Show resolved
Hide resolved
| @@ -194,32 +195,14 @@ class MagnetizedTovStar : public virtual evolution::initial_data::InitialData, | |||
| using tov_star = RelativisticEuler::Solutions::TovStar; | |||
|
|
|||
| public: | |||
| struct PressureExponent { | |||
| using type = size_t; | |||
| struct MagneticFields { | |||
There was a problem hiding this comment.
update the class documentation to using arbitrary fields
| 2, 0.04, 2500.0, std::array{0.0, 0.0, 0.0}, 100.0), | ||
| std::make_unique< | ||
| grmhd::AnalyticData::InitialMagneticFields::Toroidal>( | ||
| 2, 0.04, 2500.0, std::array{0.0, 0.0, 0.0}, 100.0)))); |
There was a problem hiding this comment.
Add a test where you compare the created B field from two different solutions where the InitialMagneticField pointers are in order (Poloidal, Toroidal) vs (Toroidal, Poloidal)
src/PointwiseFunctions/AnalyticData/GrMhd/InitialMagneticFields/Poloidal.cpp
Outdated
Show resolved
Hide resolved
nilsdeppe
force-pushed
the
bns_simulations
branch
from
dc6c932
to
6b19603
Compare
|
Rebased and pushed fixups. Thanks for the review! |
kidder
reviewed
Oct 19, 2023
tests/Unit/PointwiseFunctions/AnalyticData/GrMhd/Test_MagnetizedTovStar.cpp
Show resolved
Hide resolved
nilsdeppe
force-pushed
the
bns_simulations
branch
from
6b19603
to
4f054ef
Compare
kidder
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #4562
We will also be able to add a mutator or something to add it to the numerical initial data. I haven't looked into that, but that'll allow us to superpose a B-field in BNS simulations quite easily.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments