Radially falling floor EoS call #5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
requested changes
Oct 10, 2023
| specific_internal_energy->get()[i] = | ||
| get(equation_of_state.specific_internal_energy_from_density( | ||
| Scalar<double>{density->get()[i]})); | ||
|
|
There was a problem hiding this comment.
Should this also recompute T? Since that's what we reconstruct that needs to be consistent
There was a problem hiding this comment.
Updated. I thought temperature defaults to 0 for 1D EoS, but I have included it.
pajkosmi
force-pushed
the
radially_falling_floor_eos
branch
from
6cc4adc
to
fc90126
Compare
|
Updated and squashed |
nilsdeppe
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
EoS call after radially falling floor is implemeneted. Completes issue #5520.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments