Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executable summarizing time stepper properties #5559

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Oct 11, 2023

$ bin/TimeStepperSummary --sort 'stab/esubs'
name                 order subs esubs stab   stab/subs stab/esubs IMEX LTS 
---------------------------------------------------------------------------
AdamsBashforth[8]    8     1    1     0.0122 0.0122    0.0122     N    Y   
AdamsBashforth[7]    7     1    1     0.0233 0.0233    0.0233     N    Y   
AdamsBashforth[6]    6     1    1     0.0439 0.0439    0.0439     N    Y   
AdamsBashforth[5]    5     1    1     0.0817 0.0817    0.0817     N    Y   
AdamsMoultonPc[8]    8     2    2     0.264  0.132     0.132      N    N   
...

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clang-tidy wants some gsl::ats. I think this will be really useful. Something I've definitely wanted :D

@wthrowe
Copy link
Member Author

wthrowe commented Oct 12, 2023

Fixed ats. Also moved <boost/program_options.hpp> from the top into the main include list because I have no idea why I put it separately.

@nilsdeppe nilsdeppe merged commit 3783115 into sxs-collaboration:develop Oct 13, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants