Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Catch2 version to 3.4.0 #5561

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Oct 11, 2023

Proposed changes

We used some features introduced in v3.3.0 by accident.

Upgrade instructions

Building unit tests requires Catch2 v3.4.0 now. See the Catch2 docs for installation instructions (it's a standard CMake configure-build-install).

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added the build system CMake build system label Oct 11, 2023
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wheeler, CaltechHPC, and Ocean now all have Catch2 v3.4 modules that can be used. I talked to @geoffrey4444 and there will be a separate PR to update the ocean modules.

@knelli2 knelli2 merged commit 7b70d90 into sxs-collaboration:develop Oct 16, 2023
22 checks passed
@nilsvu nilsvu deleted the catch2_version branch October 17, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system CMake build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants