Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wcns5z for ghmhd, add Enable options to LimitLorentz & FixConservatives #5562

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

nilsdeppe
Copy link
Member

Proposed changes

Upgrade instructions

Need to add

    Enable: false # Only needed when not using Kastaun for recovery

(or true) to FixConservatives and LimitLorentzFactor in input files.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@ffoucart
Copy link
Contributor

Seems fine to me; we'll just have to add the lower velocity to the WENO reconstructor's inputs.

@nilsdeppe
Copy link
Member Author

I'm trying to find where in develop we have that input. Or is this something you're adding?

@ffoucart
Copy link
Contributor

Oh, that's the change you made to all the reconstructors to allow the calculation of the sound speed. It's not in develop; we'll just have to make the change when we merge the sound speed changes.

@nilsdeppe
Copy link
Member Author

Ah okay, yea that should be straightforward enough to update when we get there :)

@nilsdeppe nilsdeppe merged commit 71112b4 into sxs-collaboration:develop Oct 13, 2023
21 of 22 checks passed
@nilsdeppe nilsdeppe deleted the wcns5z_ghmhd branch October 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants