Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow events to mutate the DataBox #5565

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Oct 13, 2023

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Comment on lines 50 to 52
using compute_item_tags = tmpl::list<ComputeTags...>;
/// A list of all the compute item tags that are compute items
using actual_compute_item_tags =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we come up with a better naming scheme than thing and actual_thing? If the original compute_item_tags isn't only compute items, maybe rename it to just item_tags? The class template pack should probably also change then since they aren't necessarily ComputeTags.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the new alias was only used in one place, I just inlined it.

I think renaming to item_tags would be confusing as there is already a tags_list that means something else.

@knelli2 knelli2 merged commit 5a10027 into sxs-collaboration:develop Oct 19, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants