Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NeighborPackagedData to ForceFree subcell #5568

Merged

Conversation

yoonso0-0
Copy link
Contributor

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

@yoonso0-0
Copy link
Contributor Author

Test mostly follows that of ScalarAdvection subcell.

@yoonso0-0 yoonso0-0 force-pushed the ffe/subcell/neighbor_pkgd branch 3 times, most recently from a879474 to 5684ce1 Compare October 25, 2023 00:20
@yoonso0-0 yoonso0-0 force-pushed the ffe/subcell/neighbor_pkgd branch 2 times, most recently from 7d2db87 to 984dae1 Compare October 26, 2023 21:42
@kidder kidder merged commit 24bdc86 into sxs-collaboration:develop Nov 8, 2023
20 of 22 checks passed
@yoonso0-0 yoonso0-0 deleted the ffe/subcell/neighbor_pkgd branch November 8, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants