Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smaller values in scalar wave char test #5571

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Oct 18, 2023

Proposed changes

Fixes #5570. The random values of the tensors were too large so they were off by roundoff. Ran the test 10k times and didn't have an issue.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Oct 18, 2023
@knelli2 knelli2 requested a review from wthrowe October 18, 2023 06:56
@kidder kidder merged commit dfb3afd into sxs-collaboration:develop Oct 19, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random failure of Unit.Evolution.Systems.ScalarWave.Characteristics
3 participants