Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCE dox and HDF5 error improvements #5580

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

nilsdeppe
Copy link
Member

Proposed changes

Things Deborah Ferguson and I noticed that were unclear.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe requested a review from kidder October 21, 2023 03:11
knelli2
knelli2 previously approved these changes Oct 23, 2023
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing if you think it'll be useful

src/Evolution/Systems/Cce/BoundaryData.cpp Show resolved Hide resolved
@nilsdeppe nilsdeppe merged commit c7a5230 into sxs-collaboration:develop Oct 25, 2023
21 of 22 checks passed
@nilsdeppe nilsdeppe deleted the cce_errors_dox branch October 25, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants