Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use Catch2 for benchmarks" #5582

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

nilsdeppe
Copy link
Member

Proposed changes

This reverts commit c3c02f5.

Catch2's benchmarking capabilities are extremely primitive and not very useful in a practical situation. We need Google Benchmark.

Closes #5581

Basically, I can't actually optimize code very effectively with Catch2's benchmarking capabilities. Things like roofline analyses are not possible at all as far as I can tell.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe requested a review from kidder October 21, 2023 14:54
This reverts commit c3c02f5.

Catch2's benchmarking capabilities are extremely primitive and not very useful
in a practical situation. We need Google Benchmark.
@knelli2
Copy link
Contributor

knelli2 commented Oct 23, 2023

Test errors unrelated

@knelli2 knelli2 merged commit f17af07 into sxs-collaboration:develop Oct 23, 2023
20 of 22 checks passed
@nilsdeppe nilsdeppe deleted the revert_benchmark branch December 4, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-add Google Benchmark
4 participants