Construct DataVector from STL containers #5587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
requested changes
Oct 26, 2023
src/DataStructures/VectorImpl.hpp
Outdated
| @@ -199,6 +199,18 @@ class VectorImpl | |||
| std::fill(data(), data() + set_size, value); | |||
| } | |||
|
|
|||
| // Create from a copy of the given container | |||
|
@nilsvu will look into this |
nilsvu
force-pushed
the
dv_from_container
branch
2 times, most recently
from
59b656f
to
89651b1
Compare
nilsdeppe
reviewed
Aug 21, 2024
src/DataStructures/VectorImpl.hpp
Outdated
| /// | ||
| /// \param container A container with a `value_type` that is the same as `T`. | ||
| /// Currently restricted to `std::vector<T>` and `std::array<T>`. | ||
| template <typename Container, typename U = typename Container::value_type, |
There was a problem hiding this comment.
Why not inline the Container::value_type on the next line?
Various places in the code rolled their own solution to this.
nilsvu
force-pushed
the
dv_from_container
branch
from
89651b1
to
2555874
Compare
nilsdeppe
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various places in the code rolled their own solution to this.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments