Print more info on AHfinder failure. #5597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markscheel
force-pushed
the
MoreInfoForAhInterpFailure
branch
2 times, most recently
from
bfc0cbc
to
195e93f
Compare
knelli2
reviewed
Oct 26, 2023
Comment on lines
+57
to
+60
| ERROR("Apparent horizon finder " | ||
| << pretty_type::name<InterpolationTargetTag>() | ||
| << " failed, reason = " << failure_reason << os.str()); |
There was a problem hiding this comment.
Also write the temporal id? Could even do it below in general as well
There was a problem hiding this comment.
done (and squashed).
markscheel
force-pushed
the
MoreInfoForAhInterpFailure
branch
from
195e93f
to
5187ac2
Compare
|
@knelli2 can this be merged? |
knelli2
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If the AH finder fails because it cannot interpolate to some points, now it prints the
points that it cannot interpolate to.
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.