Prevent operations with DV expressions in translation map #5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also explicitly specify a few other 'auto' variables
wthrowe
approved these changes
Oct 27, 2023
| @@ -348,7 +348,7 @@ std::array<tt::remove_cvref_wrap_t<T>, Dim> Translation<Dim>::piecewise_helper( | |||
| for (size_t i = 0; i < Dim; i++) { | |||
| gsl::at(result, i) = gsl::at(source_coords, i); | |||
| } | |||
| auto radius = magnitude(result); | |||
| const tt::remove_cvref_wrap_t<T> radius = magnitude(result); | |||
There was a problem hiding this comment.
This was giving a Blaze expression referencing result, so reading from it took into account changes to result that had happened after here until that point.
I believe all the other lines were correct, but some of them are probably more efficient with these changes, so that's also good.
3 tasks
|
Thanks for fixing this. I get no error message with Bjorus now and it seems to run ok. |
guilara
approved these changes
Oct 27, 2023
|
@knelli2 Done. I didn't know where the approve button was 😅 |
1 similar comment
|
@knelli2 Done. I didn't know where the approve button was 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also explicitly specify a few other 'auto' variables
Proposed changes
Not exactly sure what was happening, but this fixes issues that @guilara was having when testing the addition of the Translation map to the Sphere domain creator.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments