Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register derived parallel callbacks #5607

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Oct 30, 2023

Proposed changes

The GlobalCache never really gets pupped, but it is sized by the MemoryMonitor. Therefore, all it's members need to be registered with charm. Before the derived callbacks weren't registered, so we got the Unrecognized PUP::able::PUP_ID error. This PR will register the callbacks only once so that doesn't happen.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@@ -6,6 +6,7 @@
#include <algorithm>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong class name in the commit message. (Should be MockDistributedObjectProxy.)

@wthrowe wthrowe merged commit 03a2054 into sxs-collaboration:develop Nov 7, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants