Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gauss points in elliptic DG schemes #5608

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Oct 30, 2023

Proposed changes

Upgrade instructions

In elliptic executables add the Discretization.DiscontinuousGalerkin.Quadrature option. Set it to GaussLobatto to keep the previous behavior.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu force-pushed the gauss_points branch 2 times, most recently from ef72aee to 60f30aa Compare October 31, 2023 16:39
nilsdeppe
nilsdeppe previously approved these changes Oct 31, 2023
@kidder
Copy link
Member

kidder commented Nov 1, 2023

@nilsvu this needs a rebase

@nilsvu
Copy link
Member Author

nilsvu commented Nov 1, 2023

Rebased.

@nilsvu nilsvu merged commit 52469ba into sxs-collaboration:develop Nov 2, 2023
19 of 22 checks passed
@nilsvu nilsvu deleted the gauss_points branch November 2, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants