Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doxygen warnings for certain functions #5620

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix doxygen warnings for certain functions #5620

merged 1 commit into from
Nov 9, 2023

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Nov 9, 2023

Proposed changes

Not a great fix...but a fix nonetheless...

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added priority critical for progress bugfix labels Nov 9, 2023
nilsvu
nilsvu approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 🤷‍♂️ thanks for fixing this!

@nilsvu
Copy link
Member

nilsvu commented Nov 9, 2023

Merging now to fix CI.

@nilsvu nilsvu merged commit 0a03510 into sxs-collaboration:develop Nov 9, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsvu nilsvu nilsvu approved these changes

Assignees
No one assigned
Labels
bugfix priority critical for progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knelli2 @nilsvu