Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of testing framework code #5622

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

kidder
Copy link
Member

@kidder kidder commented Nov 11, 2023

Proposed changes

Small changes aimed at reducing code complexity in order to improve compile time and reduce code coupling.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@@ -9,6 +9,7 @@ spectre_target_sources(
${LIBRARY}
PRIVATE
Abort.cpp
Exit.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to actually make the dependence on Charm PRIVATE in this file as the commit message promises? If so I think it would be good to also add a comment there why you made it private so it won't accidentally be made public again later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, but I couldn't get it to work because we still have some cyclic library dependencies. I'll remove the comment from the commit message

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you understand the cyclic dependency? How can making a dependency private introduce a cyclic dependency?

@kidder
Copy link
Member Author

kidder commented Nov 16, 2023

@nilsvu any other comments or requested changes?

Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilsvu nilsvu merged commit f9f6a87 into sxs-collaboration:develop Nov 17, 2023
19 of 22 checks passed
@kidder kidder deleted the consolidate_iterable_approx branch November 17, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants