-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WorldtubeBufferUpdater and WorldtubeDataManager for CCE #5640
WorldtubeBufferUpdater and WorldtubeDataManager for CCE #5640
Conversation
I've tested the executable |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Squash all the fixups including these last few changes.
3fac882
to
85e7d6e
Compare
Done. I noticed that the first argument of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. You can squash the final fixup
7d78708
to
379f0c6
Compare
Ok, squashed. |
Proposed changes
This PR aims to pave the path for dealing with the worldtube data of the Klein-Gordon CCE system. Two major changes are introduced to the current infrastructure
WorldtubeDataManager
is hard-coded to handleTags::characteristic_worldtube_boundary_tags<Tags::BoundaryValue>
. This can be relaxed so that it can be used to deal with other worldtube data (say a scalar field).WorldtubeBufferUpdater
andWorldtubeDataManager
, and will be more once they are extended to handle the Klein-Gordon system. I extract some common parts into functions to avoid more copy and paste.Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments