Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutate NeighborMesh at beginning of AMR #5643

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

kidder
Copy link
Member

@kidder kidder commented Nov 28, 2023

Proposed changes

Update the meshes held by ::domain::Tags::NeighborMesh at the start of AMR so they may be used by other AMR projectors.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@kidder kidder requested a review from nilsvu November 28, 2023 19:33
This will allow the NeighborMesh tag to be used by the elliptic solver.
This allows other AMR projectors to use knowledge of the meshes of the
neighbors.
@kidder kidder merged commit 59fc369 into sxs-collaboration:develop Dec 5, 2023
22 checks passed
@kidder kidder deleted the neighbor_mesh branch December 5, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants