-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function for the spacetime derivative of goth(g) #5648
Conversation
src/PointwiseFunctions/GeneralRelativity/SpacetimeDerivativeOfGothG.cpp
Outdated
Show resolved
Hide resolved
|
||
template <typename DataType, size_t SpatialDim> | ||
void test_compute_spacetime_deriv_of_goth_g(const DataType& used_for_size) { | ||
pypp::check_with_random_values<1>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also test by making up values for the metric (doesn't have to be meaningful, just some smooth functions) and taking a numerical derivative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After further discussion between us, we decided that this one would not be worth the effort of pursuing.
N.B. the latest update includes a modification to the function switching the |
src/PointwiseFunctions/GeneralRelativity/SpacetimeDerivativeOfGothG.cpp
Outdated
Show resolved
Hide resolved
src/PointwiseFunctions/GeneralRelativity/SpacetimeDerivativeOfGothG.cpp
Outdated
Show resolved
Hide resolved
src/PointwiseFunctions/GeneralRelativity/SpacetimeDerivativeOfGothG.cpp
Outdated
Show resolved
Hide resolved
src/PointwiseFunctions/GeneralRelativity/SpacetimeDerivativeOfGothG.cpp
Outdated
Show resolved
Hide resolved
src/PointwiseFunctions/GeneralRelativity/SpacetimeDerivativeOfGothG.cpp
Outdated
Show resolved
Hide resolved
ca2d9b8
to
7fac324
Compare
Proposed changes
Adds a function to compute the spacetime derivative of goth(g), defined as the product of the spacetime metric and square root of the absolute value of its determinant.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments
This quantity is defined on p. 466 in Misner, Thorne, and Wheeler, Gravitation.