Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for the spacetime derivative of goth(g) #5648

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

ncorsobh
Copy link
Contributor

@ncorsobh ncorsobh commented Dec 4, 2023

Proposed changes

Adds a function to compute the spacetime derivative of goth(g), defined as the product of the spacetime metric and square root of the absolute value of its determinant.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

This quantity is defined on p. 466 in Misner, Thorne, and Wheeler, Gravitation.


template <typename DataType, size_t SpatialDim>
void test_compute_spacetime_deriv_of_goth_g(const DataType& used_for_size) {
pypp::check_with_random_values<1>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also test by making up values for the metric (doesn't have to be meaningful, just some smooth functions) and taking a numerical derivative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further discussion between us, we decided that this one would not be worth the effort of pursuing.

@ncorsobh
Copy link
Contributor Author

N.B. the latest update includes a modification to the function switching the da_lapse argument with a dt_lapse and deriv_lapse, since these are calculated separately in GH. They are combined back into da_lapse within the function.

@ncorsobh ncorsobh force-pushed the quadrupole branch 2 times, most recently from ca2d9b8 to 7fac324 Compare December 12, 2023 02:58
@wthrowe wthrowe merged commit 71f9b70 into sxs-collaboration:develop Dec 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants